Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving efficiency and functionality #148

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Improving efficiency and functionality #148

wants to merge 17 commits into from

Conversation

tiamo
Copy link
Member

@tiamo tiamo commented Jan 6, 2025 •
edited
Loading

What's New

Fixes:

  • Restrict the ability to update provider URLs exclusively to the controller principal.
  • New HTTP request cost calculation.
  • Support commitment level for sol_requestAirdrop.
  • Fixed transaction encoding param for sol_sendTransaction and sol_simulateTransaction.
  • Add commitment validation for requests that do not support the processed level.

Improvements:

  • RPC tests improved.
  • Implement AsRef<str> for Cluster for better performance.

Features:

  • Added balance method for wallet canister.

In Progress

  • Implement transformation functions for each method to canonicalize the
    responses which allows ICP nodes to reach consensus.
  • Ensure that provider costs are reflected in the HTTP outcall cycle cost
    calculation.

tiamo added 17 commits January 6, 2025 23:16
@tiamo
refactor: improve Cluster performnce, add as_ref
e81c021
@tiamo
refactory: code cleanup
26ba08c
@tiamo
fix: http reqeust cost calculation
19f1886
@tiamo
refactor: transaction encoding
b70b886
@tiamo
fix: support commitmentConfig in requestAirdrop
86af721
@tiamo
fix: update provider (disable manager url change)
b02b138
@tiamo
refactor: providers management
b952da3
@tiamo
test: rpc tests improved
41543bb
@tiamo
refactor: improve http reqeust ransform
271f553
@tiamo
refactor: global improvements
5c9b8a6
@tiamo
fix: transaction encoding for send_transaction and `simulate_transa…
ddf1186 
…ction`
@tiamo
refactor(wallet): extract caller_pubkey nad caller_sign
309db96
@tiamo
feat(wallet): add balance method
8294152
@tiamo
refactor(wallet): global improvements
170332f
@tiamo
chore: add new wasm files
00105c5
@tiamo
chore: remove unused code
73fc4fd
@tiamo
fix: add commitment for requests that do not support the processed …
3ed64a6 
…level
@tiamo tiamo changed the title Improving Efficiency and Functionality Improving efficiency and functionality Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tiamo